Repository navigation
docs(providers): keep specialized providers as explicit instances - #53
Merged
Merged
Conversation
Issue 22 asked whether memory, image and video providers should get a declaration decorator like @tool or @platform. They should not. A provider is one stateful instance the plugin builds, often behind a runtime policy the plugin already evaluates for its other surfaces; its only consumer gates it in one line. A decorator would construct the instance itself, assume a no-argument constructor, and add a second activation gate. README and the authoring skill now say so and show the gated tuple. The skill's surface map gains a specialized-provider row, its "does not own" list no longer reads as if the kit had no provider path, AGENTS.md records the decision, and the public-surface guard treats the three provider ABCs as host-owned. Closes: #22 Claude-Session: https://claude.ai/code/session_01B6XeAWUPdrx34tr5dTg5dY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the open question in #22: specialized providers stay explicit instances passed through
memory_providers=,image_gen_providers=andvideo_gen_providers=. No declaration decorator is added.Why
() if policy.read_only else (MemPalaceMemoryProvider(),).resolve_capability_selection.@tool,@hookand@platformdeclare things the host calls or constructs; providers are a different shape, so the asymmetry is the contract, not a gap.Decided with the owner on 2026-11-13 over two alternatives: a class decorator (
@memory_provider(enabled=...)) and a typedplugin_provider(...)declaration.Changes
tests/test_testing_harness.py: the public-surface guard treatsMemoryProvider,ImageGenProviderandVideoGenProvideras host-owned, as it already doesContextEngine.No runtime code changes. The survey found nothing to build.
Verification
mise run test: 330 run, 26 skipped, EXIT=0.Closes: #22
https://claude.ai/code/session_01B6XeAWUPdrx34tr5dTg5dY